feat(spec): read timestamp_ns/timestamptz_ns default values in the Literal JSON codec#2832
Merged
blackmwk merged 2 commits intoJul 16, 2026
Merged
Conversation
Kurtiscwright
approved these changes
Jul 16, 2026
Kurtiscwright
left a comment
Kurtiscwright
left a comment
Contributor
There was a problem hiding this comment.
Thank you, this looks great.
QQ: Should we add tests with different time zones?
Mirror Java's testInvalidTimestamptz{,Nano}: only +00:00 is valid per
spec, so a non-UTC offset must be rejected.
Collaborator
Author
Good call, added tests for it. Spec says the offset must be +00:00 and Java enforces the same ( One note: we accept only the literal +00:00, not Z like Java does — spec mandates +00:00 and both writers emit it, so round-trips are fine. I would keep it strict for now. |
NoahKusaba
added a commit
to NoahKusaba/iceberg-rust
that referenced
this pull request
Jul 16, 2026
…ion-ballista Brings the ballista branch in-line with catalog-config: Variant support (apache#2188), encrypted parquet data-file reads (apache#2584), timestamp_ns default literals (apache#2832), and the format_version auto-selection in SchemaProvider::create_table. Regenerated Cargo.lock and all DEPENDENCIES.rust.tsv files; workspace + tests compile on datafusion 54 / ballista 54.
NoahKusaba
pushed a commit
to NoahKusaba/iceberg-rust
that referenced
this pull request
Jul 16, 2026
…teral JSON codec (apache#2832) ## Which issue does this PR close? We don't have an issue for this. Deserializing Timestamp NS default values failed. ## What changes are included in this PR? `try_into_json` serialized TimestampNs/TimestamptzNs but `try_from_json` had no matching arms, so a nanosecond-timestamp single value (e.g. a column default) failed to deserialize (fell to the DataInvalid catch-all). Add the read arms mirroring the microsecond ones, plus `datetime_to_nanoseconds` / `datetimetz_to_nanoseconds` helpers. Also adds json_timestamp_ns / json_timestamptz_ns tests. ## Are these changes tested? Yes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
We don't have an issue for this. Deserializing Timestamp NS default values failed.
What changes are included in this PR?
try_into_jsonserialized TimestampNs/TimestamptzNs buttry_from_jsonhad no matching arms, so a nanosecond-timestamp single value (e.g. a column default) failed to deserialize (fell to the DataInvalid catch-all). Add the read armsmirroring the microsecond ones, plus
datetime_to_nanoseconds/datetimetz_to_nanosecondshelpers. Also adds json_timestamp_ns / json_timestamptz_ns tests.Are these changes tested?
Yes